register-enrol issueshttps://git.oeru.org/oeru/register-enrol/-/issues2021-09-26T23:42:08Zhttps://git.oeru.org/oeru/register-enrol/-/issues/19Further accessibility improvement suggestions2021-09-26T23:42:08ZDave LaneFurther accessibility improvement suggestionsMany thanks to Greg Gay (from Ryerson) for his very useful feedback and guidance!
1. For the inline red error messages, add a role="alert" to the elements containing the messages. This will force screen readers to read them when they ap...Many thanks to Greg Gay (from Ryerson) for his very useful feedback and guidance!
1. For the inline red error messages, add a role="alert" to the elements containing the messages. This will force screen readers to read them when they appear, without having to go looking for the messages.
2. For the X button to close the registration, welcome, update password, and login dialogs, add a text label "close". An aria-label="close" would work for this purpose, added to the button markup. They currently announce as "button".
3. The success dialog that opens after logging in, opens briefly, but then disappears before I, with vision, can read the message or get to the OK button, and the screen reader does not seem to notice that dialog. It does not block logging in with the screen reader, but it would make it more difficult to tell whether the login was successful.
4. Optionally you could include a success dialog/message after logging out.
I did not go through a full registration, to see what happens after. But, maybe extrapolate from the above and apply that to whatever happens after successfully (or not) registering.Dave LaneDave Lanehttps://git.oeru.org/oeru/register-enrol/-/issues/18Menu behaviour with keyboard navigation2021-09-20T02:10:27ZDave LaneMenu behaviour with keyboard navigationSubmitted by Greg Gay: Also noticed a couple other accessibility issues with the main menu. I can get through it with the Tab key (in a round about way), but not with the arrow keys. And, submenus remain open when navigating away from th...Submitted by Greg Gay: Also noticed a couple other accessibility issues with the main menu. I can get through it with the Tab key (in a round about way), but not with the arrow keys. And, submenus remain open when navigating away from them. They should close when focus leaves the submenu, or the ESC key is pressed.
Ref: https://www.w3.org/TR/wai-aria-practices-1.1/examples/menubar/menubar-1/menubar-1.htmlDave LaneDave Lanehttps://git.oeru.org/oeru/register-enrol/-/issues/17Ensure keyboard focus stays within menus/modal dialogs unless explicitly dism...2021-09-20T02:11:30ZDave LaneEnsure keyboard focus stays within menus/modal dialogs unless explicitly dismissedSubmitted by Greg Gay: Once a menu or modal dialog is opened it is possible to navigate and submit the form, though when navigating through it focus leaves the dialog and returns to the content in behind it. Focus should remain in popup...Submitted by Greg Gay: Once a menu or modal dialog is opened it is possible to navigate and submit the form, though when navigating through it focus leaves the dialog and returns to the content in behind it. Focus should remain in popup dialogs until manually dismissed (i.e. Esc), or the login or register link etc. are pressed.
Ref: https://www.w3.org/TR/wai-aria-practices-1.1/examples/dialog-modal/dialog.htmlhttps://git.oeru.org/oeru/register-enrol/-/issues/16Trigger login/register menu via keyboard2021-08-22T22:19:52ZDave LaneTrigger login/register menu via keyboardSubmitted by Greg Gay: the Login/Register link though it still takes focus, is no longer keyboard operable. Dave had fix this at one point, though we now seem to have lost access to the register/login popup using a keyboard.Submitted by Greg Gay: the Login/Register link though it still takes focus, is no longer keyboard operable. Dave had fix this at one point, though we now seem to have lost access to the register/login popup using a keyboard.Dave LaneDave Lanehttps://git.oeru.org/oeru/register-enrol/-/issues/15Improve usability of feedback messages2020-02-10T20:14:39ZDave LaneImprove usability of feedback messagesThe way we've presented the feedback messages (red text) in the
registration form, using multiple labels when the form is submitted with missing input, works, but typically, these would be
presenting using ARIA role="alert" and sending f...The way we've presented the feedback messages (red text) in the
registration form, using multiple labels when the form is submitted with missing input, works, but typically, these would be
presenting using ARIA role="alert" and sending focus to the first field with missing/incorrect data. I don't think you need to change the messaging. But, for future reference, ARIA alerts generally serve this purpose.Dave LaneDave Lanehttps://git.oeru.org/oeru/register-enrol/-/issues/14Improve modal behaviour2021-09-20T02:12:37ZDave LaneImprove modal behaviourThe dialogs are all modals, so should be marked up with related WAI-ARIA (see https://www.w3.org/TR/wai-aria-practices/#dialog_modal). Modals should trap the cursor in the dialog, with focus looping through the dialog, rather than moving...The dialogs are all modals, so should be marked up with related WAI-ARIA (see https://www.w3.org/TR/wai-aria-practices/#dialog_modal). Modals should trap the cursor in the dialog, with focus looping through the dialog, rather than moving to the page in behind the dialog when focus reaches the last element. Dialog are closed by either user input (submitting registration or login), or using the Escape key. If the dialog is dismissed, focus should return to where the dialog was opened
from.Dave LaneDave Lanehttps://git.oeru.org/oeru/register-enrol/-/issues/13Add keyboard navigation to ensure Register Enrol interface is accessible.2020-02-10T20:16:26ZDave LaneAdd keyboard navigation to ensure Register Enrol interface is accessible.Thanks to Greg Gay for this request...Thanks to Greg Gay for this request...Dave LaneDave Lanehttps://git.oeru.org/oeru/register-enrol/-/issues/12Add "Assign blog feed" on enrolled user menu.2019-07-24T03:37:39ZDave LaneAdd "Assign blog feed" on enrolled user menu.Add a link (which opens a separate window/tab, so use a different link style) to the "You are logged in as..." dialogue which allows an enrolled learner to nominate a personal blog feed URL (via the [Blog Feed Finder](/oeru/blog-feed-fin...Add a link (which opens a separate window/tab, so use a different link style) to the "You are logged in as..." dialogue which allows an enrolled learner to nominate a personal blog feed URL (via the [Blog Feed Finder](/oeru/blog-feed-finder) easily, rather than having to hunt around for it as is currently the case.Dave LaneDave Lanehttps://git.oeru.org/oeru/register-enrol/-/issues/11Previous country selection incorrectly displayed instead of new country selec...2019-05-06T02:18:28ZWayne MackintoshPrevious country selection incorrectly displayed instead of new country selection when editing profileWhen a logged-in user attempts to edit country of origin using the "Edit Profile" modal on Wordpress:
* User can correctly select revised country of origin from pull-down list
* When clicking the Save button, the Modal incorrectly disp...When a logged-in user attempts to edit country of origin using the "Edit Profile" modal on Wordpress:
* User can correctly select revised country of origin from pull-down list
* When clicking the Save button, the Modal incorrectly displays the previous selected country (not the new country selection) when the modal "refreshes" while displaying the "Processing button message"
* However, new country is correctly recorded - but this bug is confusing for users because the wrong country is being displayed to the user (i.e. the previous country selection.)Dave LaneDave Lanehttps://git.oeru.org/oeru/register-enrol/-/issues/10Country of origin option displaying incorrect error message on the "Register"...2019-05-06T02:18:28ZWayne MackintoshCountry of origin option displaying incorrect error message on the "Register" modal on WordpressWhen registering a new user on WordPress, after selecting a country in the pull-down list and clicking the "Register" button, the following error message is displayed "You must select the country with which you most closely associate".
...When registering a new user on WordPress, after selecting a country in the pull-down list and clicking the "Register" button, the following error message is displayed "You must select the country with which you most closely associate".
This error message should not be displayed if the user has selected a country.
However, the country selected by the user is recorded correctly under the corresponding Mautic contact.Dave LaneDave Lanehttps://git.oeru.org/oeru/register-enrol/-/issues/9New user registration not assigned to relevant Mautic course segment on 1st r...2019-05-08T09:32:53ZWayne MackintoshNew user registration not assigned to relevant Mautic course segment on 1st registrationWhen registering a new user account on a course site on course.oeru.org, the new user is not assigned to the corresponding Mautic segment on the first registration. (However, if this user leaves the course site (unenroll) and enrolls aga...When registering a new user account on a course site on course.oeru.org, the new user is not assigned to the corresponding Mautic segment on the first registration. (However, if this user leaves the course site (unenroll) and enrolls again via WordPress, the user is then correctly assigned to the corresponding Mautic segment.
**State after 1st login of new user:**
1. User correctly shown as "Enrolled" in the user status link on WordPress.
2. New user correctly appears in the Mautic-sync user list in WordPress (after refresh)
3. New user correctly created as new Mautic contact in Mautic and correctly displayed as link in the "Mautic contact" column in the Mautic-sync user list in WordPress.
4. However contact in Mautic **is not assigned** to the relevant independent study segment in Mautic - even though status on WordPress is shown as "Enrolled".Dave LaneDave Lanehttps://git.oeru.org/oeru/register-enrol/-/issues/8Enhance Course content to include microcourse title as a field2018-11-26T04:20:11ZDave LaneEnhance Course content to include microcourse title as a fieldCurrently, a subsite/course has a title - see `get_blog_details($site_id)->blogname`, and a path (which includes, by our convention, the short course code or "tag") `get_blog_details($site_id)->pathinfo` (the actual course code is extrac...Currently, a subsite/course has a title - see `get_blog_details($site_id)->blogname`, and a path (which includes, by our convention, the short course code or "tag") `get_blog_details($site_id)->pathinfo` (the actual course code is extracted via "function get_site_tag($site)"). The problem is that a "Course" in OERu's context has 3 bits of important information: an overarching course title, e.g. "Learning in a Digital Age", which is comprised of a few microcourses, each with a title, like "Digital literacies for online learning" (lida101), or "Digital Citizenship" (lida102), or "Open education, copyright and open licensing in a digital world" (lida103), etc. These microcourse titles are currently not represented in metadata, only as a title field in the curriculum materials.
Ideally, we should store the Course Title, and component Microcourse Titles (with their course code) separately, and those should in turn, inform the curriculum material fields and path information, not the other way around.Dave LaneDave Lanehttps://git.oeru.org/oeru/register-enrol/-/issues/7Revise text for "Enrol in this OERu course modal"2018-11-26T02:58:14ZWayne MackintoshRevise text for "Enrol in this OERu course modal"Suggested changes for the `Enrol in this OERu Course` modal (after clicking on the Enrol button on the logged in status modal)
Change modal title:
"Enrol in this OERu ~~C~~course " (i.e.lowercase "c")
Notification below `Enrol` bu...Suggested changes for the `Enrol in this OERu Course` modal (after clicking on the Enrol button on the logged in status modal)
Change modal title:
"Enrol in this OERu ~~C~~course " (i.e.lowercase "c")
Notification below `Enrol` button currently reads:
"By enrolling in this course, you are opting-in to receiving course instructions via email."
Suggest simplifying as follows:
"By enrolling you can post comments on this site and opting-in to receive course instructions via email."https://git.oeru.org/oeru/register-enrol/-/issues/6Confirm past tense of enrol2020-10-06T00:25:09ZWayne MackintoshConfirm past tense of enrolEnglish spelling uses one "l" for enrol.
Tricky question re-consistency, is the correct English past tense "enroled" - I think it should be "enrolled" - but need an English authority to check. If it proves to be enroled - we will need t...English spelling uses one "l" for enrol.
Tricky question re-consistency, is the correct English past tense "enroled" - I think it should be "enrolled" - but need an English authority to check. If it proves to be enroled - we will need to change the string in the enrolment status model (and link label specifying status.)https://git.oeru.org/oeru/register-enrol/-/issues/5Confirm source for generating course title and tag in enrolment status modal2018-11-26T02:58:31ZWayne MackintoshConfirm source for generating course title and tag in enrolment status modalIt appears that the enrollment status modal is generating the "`course title`" string from the WordPress `Site Title` field to produce for example, the following text in the modal.
"You are enrolled in "Learning in A Digital Age 102...It appears that the enrollment status modal is generating the "`course title`" string from the WordPress `Site Title` field to produce for example, the following text in the modal.
"You are enrolled in "Learning in A Digital Age 102 (dev)" followed by the course code, eg (lida102)
This works fine on wpms, but on course.oeru.org the `Site Title` field is usually the course code so depending on where you are sourcing the course code string from the database there will be duplication in the model text, for example on course.oeru.org the text in the modal would read:
"You are enrolled in LiDA101 (lida102)"
Suggested quick fix: Remove the second course code in parenthesis i.e. "(lida102)" - check that this change won't mess up the button text: `Enrol in lida102` (Not sure where you are getting the course code from in the DB.
This issue would apply to all scenarios where the modal pull the `Site title` field, eg:
* Enrol in this OERu Course modal
* Notifications which use the `Site title` field
* Others?https://git.oeru.org/oeru/register-enrol/-/issues/4Prepopulate login form with username/email after successful registration...2018-12-03T02:17:35ZDave LanePrepopulate login form with username/email after successful registration...To avoid a newly registered user needing to retype their username or email into the login form which immediately follows from clicking "Ok" on a successful registration form response, prepopulate that form with either the username or ema...To avoid a newly registered user needing to retype their username or email into the login form which immediately follows from clicking "Ok" on a successful registration form response, prepopulate that form with either the username or email. This requires that data to be passed back to Javascript as there's not yet an authenticated session...0.9 First deploymentDave LaneDave Lanehttps://git.oeru.org/oeru/register-enrol/-/issues/3Replace default WordPress auth URLs with Register-Enrol equivalents2018-11-23T04:06:24ZDave LaneReplace default WordPress auth URLs with Register-Enrol equivalentsThis will remove the somewhat jarring issue of an expired login sending a learner to WordPress default re-authenticate form, sending it to the relevant (OERu Register-Enrol) ORE form instead... to test it, of course, I need to be able t...This will remove the somewhat jarring issue of an expired login sending a learner to WordPress default re-authenticate form, sending it to the relevant (OERu Register-Enrol) ORE form instead... to test it, of course, I need to be able to expire sessions manually... will work that out.0.9 First deploymentDave LaneDave Lanehttps://git.oeru.org/oeru/register-enrol/-/issues/2Consistency of language on Login / Register modal2018-11-23T03:48:15ZWayne MackintoshConsistency of language on Login / Register modalThe current Log in /Register modal (when you 1st click the login link) uses the following text:
* **Register**: If you don't yet have an account, we invite you to
* **Log In**: If you have already registered, please
Suggested change fo...The current Log in /Register modal (when you 1st click the login link) uses the following text:
* **Register**: If you don't yet have an account, we invite you to
* **Log In**: If you have already registered, please
Suggested change for **Log In** text:
If you already have an account, pleasehttps://git.oeru.org/oeru/register-enrol/-/issues/1Log in modal: Shift "I need to register button"2018-11-23T03:54:16ZWayne MackintoshLog in modal: Shift "I need to register button"Suggested UX improvement:
When opting to log in with existing account, on the `Log in to OERu Course site` modal shift the `I need to register` button below the `Log in` button.
A user who is logging in with an existing account may cli...Suggested UX improvement:
When opting to log in with existing account, on the `Log in to OERu Course site` modal shift the `I need to register` button below the `Log in` button.
A user who is logging in with an existing account may click the first button they see without reading carefully. Shifting the 'I need to register` button below the log in button will minimise this error.Dave LaneDave Lane